rust-lang / rust-lang/rust-analyzer

Chaining multiple function calls on individual lines resets indentation when typing

Open
#13,195 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: 0.3.1194-standalone (67920f797 2022-09-04)

rustc version: 1.59.0

Chaining multiple function calls resets indentation to far-left whenever you add a new call.

Say we want to type this:

fn main() {
    let object = Object::initializer()
        .foo()
        .bar()
        .init();
}

Start by typing the main function:

fn main() {
    // Cursor is here
}

Then add the first part of the line:

fn main() {
    let object = Object::initializer() // Cursor is here
}

Now hit enter:

fn main() {
    let object = Object::initializer()
        // Cursor is here
}

Finally, start typing your first chained function call, and see the problem:

fn main() {
    let object = Object::initializer()
.foo() // Cursor un-indented completely, which is very annoying
}

You might fix the indentation manually and hit enter:

fn main() {
    let object = Object::initializer()
        .foo()
        // Cursor is here
}

But typing un-indents again:

fn main() {
    let object = Object::initializer()
        .foo()
.bar() // Cursor is here
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Reproduce the behavior in rust-analyzer using the Rust chaining examples, then trace the indentation handling for newly typed chained calls. Done means each new call remains aligned with the preceding chained call instead of returning to the far-left margin.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.