rust-lang / rust-lang/rust-analyzer

Fix diagnostics on save or on format

Open
#12,960 1 comment 2 reactions 1 assignee View on GitHub

@Young-Flash is already working on this.

Since Feb 26, 2024.

A-diagnostics C-feature S-actionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

There are some diagnostics which are safe to fix everywhere (like field-shorthand or useless-braces) and there are some diagnostics which you may not mean to fix some times, but even then, you can recover the previous state easily (unused-imports are in this category IMO, you can easily import removed things later with auto-import assist).

This issue suggests adding a list of diagnostics, empty by default, which allows r-a to fix them on save (or on format, or on another action, or configurable between them) automatically. We may still not fix all instances of diagnostics (for example, if user puts auto-import in that list, we may not fix those with multiple candidates). I think adding this config helps in development speed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.