rust-lang / rust-lang/rust-analyzer
`incorrect-ident-case` diagnostic / quickfix suggests change in macro-generated code
Open
Nobody has claimed this yet.
A-assists
A-diagnostics
C-bug
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Minimal example:
macro_rules! foo {
() => { const blub: usize = 1; }
}
foo!();
We shouldn't suggest a quickfix here and probably not even report the diagnostic. Real-life example here: https://github.com/rust-lang/rust-analyzer/issues/10591#issuecomment-947379158
Probably worth checking our other diagnostics/quick fixes for this as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the minimal macro_rules example and inspect how the incorrect-ident-case diagnostic and quickfix handle macro-generated code. Review related diagnostics and quick fixes for the same behavior; done when the example no longer reports or suggests a change for generated code and relevant cases remain covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100