rust-lang / rust-lang/rust-analyzer
Highlight related on `unsafe` token should highlight all unsafe usages in the block
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
When the cursor is on an unsafe token of an unsafe block expression or unsafe function we should highlight all unsafe operations. This requires lifting out access to the unsafe_expressions analysis in hir-ty.
Relevant code is here https://github.com/rust-lang/rust-analyzer/blob/7db73875ac0d9280ae93b14232249d9c1496583a/crates/ide/src/highlight_related.rs#L45-L75
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in crates/ide/src/highlight_related.rs around the related highlighting logic, then read the unsafe_expressions analysis in crates/hir-ty/src/diagnostics/unsafe_check.rs. Trace how that analysis can be exposed to the IDE layer. Done means placing the cursor on an unsafe token highlights all unsafe operations in its unsafe block expression or unsafe function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100