rust-lang / rust-lang/rust-analyzer

Suggestion: Automatically add missing ! in macro calls.

Open
#12,151 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-diagnostics
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

(I use Rust Analyzer via Visual Studio Code.)

I often find myself accidentally leaving out the ! when typing invocations to common macros like assert, println, etc. It would be nice if RA had an option to auto-correct that class of mistakes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. First clarify which macro calls should be recognized and how the opt-in auto-correction should behave, then identify the relevant rust-analyzer entry point and tests. Done means the agreed option works for the selected missing-! cases and is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.