rust-lang / rust-lang/rust-analyzer

Panics are too noisy

Open
#12,055 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

Currently each failed lsp request will open a notification, which makes panics annoying more than what they are. Specially with panics in semantic highlighting, the corner of screen becomes unusable. I suggest raising a single notification with a message like "There was a panic. (In which request isn't really important for people) r-a may not work properly until reload. Please report it." and become silently broken in subsequent panics. If current behavior is useful for debugging, it can be enabled via a config option.

Aside this, a config for disabling semantic highlighting in ra-fixtures (which is very cool, normally) is useful for debugging panics (if there isn't already any).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how failed LSP requests produce notifications, then inspect the semantic-highlighting path and existing configuration handling. Check whether ra-fixtures already supports disabling semantic highlighting. Done means one useful panic notification, silent subsequent panics, and a documented opt-in debugging mode if needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.