rust-lang / rust-lang/rust-analyzer

Multi cursor postfix snippets only work correctly for the first cursor

Open
#11,841 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-vscode C-bug S-unactionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer version: bc08b8eff 2022-03-28 stable

rustc version: 1.58.1 (db9d1b20b 2022-01-20)

relevant settings: N/A

match result {
    Some(_) => {
        assert!(wip.is_empty());
        /* ... */
    },
    None => {
        assert!(wip.is_empty());
        /* ... */
    }
};

In code above I want to quicky invert the assert conditions, so I select the first wip.is_empty() and select the next occurence with Ctrl+D. Then I type .not at the end and press enter.

The result is

match result {
    Some(_) => {
        assert!(!wip.is_empty());
        /* ... */
    },
    None => {
        assert!(wip.is_empty().!wip.is_empty());
        /* ... */
    }
};

(This may be an issue with VS Code, but I don't know how to tell. If so I can close this and report it to VS Code)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code with the Rust snippet, two cursors, and the .not postfix snippet. Determine whether the incorrect second expansion belongs to rust-analyzer or VS Code; done means both selected occurrences expand correctly without duplicating text.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, vscode
Domain
developer-experience, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.