rust-lang / rust-lang/rust-analyzer
Rename symbol on a proc macro fails to rename the declaration correctly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
Renaming a proc-macro at a usage site almost works: It renames all other usage sites and also tries to rename the declaration itself. However, in the latter part it changes the proc-macro function name, rather than the external derive name, i.e. the first argument to #[proc_macro_derive()].
rust-analyzer version: 5fae65dd2 2022-03-07 stable
rustc version: rustc 1.61.0-nightly (c84f39e6c 2022-03-20)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by reproducing rename from a proc-macro usage site and trace the rename handling for the declaration and its #[proc_macro_derive()] attribute. Done means the external derive name is renamed while the proc-macro function name remains unchanged, with coverage for this behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100