rust-lang / rust-lang/rust-analyzer

Call Info / Signature Help with `#[cfg]`'d out parameters is broken

Open
#11,757 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-bug S-actionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

screenshot-2022-03-18-18:29:26

u16 is the correct type there, but the name is from the wrong parameter.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Call Info / Signature Help behavior described in the issue for a function with #[cfg]-disabled parameters, using the screenshot as the expected symptom. Trace the signature-help handling in rust-analyzer and verify that the displayed parameter name and type come from the same active parameter.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.