rust-lang / rust-lang/rust-analyzer

FR: Option to add "pub" instead of "pub(crate)" when applying a fix

Open
#11,563 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-feature S-unactionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

rust-analyzer has several fixes that change the visibility of a module/function/struct.
However, these add pub(crate) which I personally dislike, because it's more verbose than pub and a meaningless distinction for a binary project.

It would be nice if there was a setting to control this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Start by locating the visibility-changing fixes and the existing settings infrastructure, then determine how a setting could control pub versus pub(crate). Done means the selected fixes consistently use the configured visibility and have coverage for both choices.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.