rust-lang / rust-lang/rust-analyzer

Match fill arms postfix

Open
#11,409 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-completion A-pattern
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

If you have

let a = Some(1);

when you type a.match and complete it, you get

match a {
    Some(_) => {},
    None => {},
}

If you have a custom enum

enum State {
    Blocked,
    Running,
    Stopped,
}
let state = State::Blocked;

typing state.match and completing it gives

match state {
    _ => {},
}

It would be nice if it produced:

match state {
    State::Blocked => todo!(),
    State::Running => todo!(),
    State::Stopped => todo!(),
}

As a note, RA has an assist to automatically fill arms:

SCR-20220204-39u

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating rust-analyzer's match postfix completion and comparing it with the existing assist that fills match arms. Verify that completing a custom enum such as State produces one todo!() arm for each variant, while preserving the existing behavior for Option.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.