rust-lang / rust-lang/rust-analyzer

Ormx macro regression: expected string literalrust

Open
#10,754 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-macro C-bug S-unactionable
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

I believe my code used to work under rust-analyzer and now doesn't, so it looks like a regression.

I'm using ormx crate with its support for a conditional_query_as! macro which checks your schema against an actual database.

I will work on a minimal reproducible repo for this later, but wanted to open the issue first since I'm not sure when will I get there.

Screenshot from 2021-11-12 15-23-59

  • vscode: rust-analyzer version: 2c0f433fd 2021-11-08 stable
  • command-line: rust-analyzer 31611da

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Create the minimal reproducible repository mentioned in the issue, using the ormx crate's conditional_query_as! macro and the reported rust-analyzer versions. Compare behavior in VS Code and on the command line, then confirm the macro is accepted as it was previously.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.