rust-lang / rust-lang/rust-analyzer

Macro expansion recurses endlessly?

Open
#10,256 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-macro
Dominant language
Rust
Stars
16.9k
Forks
2.2k
Avg merge
1d 12h
Merged PRs (30d)
72

Description

The following macro + invocation(taken from https://github.com/rust-lang/rust/issues/88577#issuecomment-914665202) seems to recurse endlessly(or just takes a very long time?) even emitting a warning in name res, [WARN hir_def::nameres::collector] macro expansion is too deep

macro_rules! many_args {
    ([$($t:tt)*]#$($h:tt)*) => {
        many_args!{[$($t)*$($t)*]$($h)*}
    };
    ([$($t:tt)*]) => {
        fn _f($($t: ()),*) {}
    }
}

many_args!{[_]########## ######}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the macro_rules! definition and invocation shown in the issue, then observe the [WARN hir_def::nameres::collector] macro expansion is too deep warning. Trace the expansion until the excessive recursion or long runtime is understood; done means this input no longer recurses endlessly or takes an impractical amount of time.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.