rust-lang / rust-lang/rust-analyzer
Auto-import should respect `#[test]` functions
Open
Nobody has claimed this yet.
S-actionable
- Dominant language
- Rust
- Stars
- 16.9k
- Forks
- 2.2k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 72
Description
It should either put the imports into the function body or mark the imports with #[cfg(test)] when the function doesn't live in a #[cfg(test)] module. We probably want to prefer having the latter(or even better have this configurable).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the auto-import implementation and its handling of functions annotated with #[test]; reproduce the issue in a test case where the function is outside a #[cfg(test)] module. Done means generated imports are either placed inside the function or marked with #[cfg(test)], with the preferred behavior clarified or made configurable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100