Move SliceIndex type parameter to parameters
Open
Nobody has claimed this yet.
T-libs
- Dominant language
- Markdown
- Stars
- 6.6k
- Forks
- 1.7k
- Avg merge
- 16h 14m
- Merged PRs (30d)
- 1
Description
If I have a struct like this:
struct T1 {}
struct T2 {}
pub struct Aggregate {
v1: Vec<T1>,
v2: Vec<T2>,
}
impl Aggregate {
pub fn compute<R>(&self, range: R) -> Option<u32> {
for v in self.v1.get(range)? {
output += v.compute();
}
for v in self.v2.get(range)? {
output += v.compute();
}
Some(output)
}
}
The type bound for R would need to be R: SliceIndex<[T1]> + SliceIndex<[T2]>, which exposes internal implementation details.
I propose moving the <T> in SliceIndex<T> to the methods and leverage GATs:
trait SliceIndex : Sized {
type Output<T: ?Sized>: ?Sized;
fn get<T: ?Sized>(self, slice: &T) -> Option<&Self::Output<T>>;
fn get_mut<T: ?Sized>(self, slice: &mut T) -> Option<&mut Self::Output<T>>;
// ...
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository file, test, or entry point is named. Start by reviewing the SliceIndex examples and proposed GAT-based API in the issue, then follow the RFC process for the design. Done means reaching agreement on the scope and API for moving the type parameter to methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100