rust-lang / rust-lang/rfcs

Match arrays against byte strings

Open
#3,291 7 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Markdown
Stars
6.6k
Forks
1.7k
Avg merge
16h 14m
Merged PRs (30d)
1

Description

Hi,

Today i have to do this:

const MVHD: [u8;4] = *b"mvhd";
match header.id {
    BoxType::Id(BoxId(MVHD)) => self.mvhd = Some(MvhdBox::read(header, reader).await?),
    // Or
    BoxType::Id(BoxId([b'm', b'v', b'e', b'x'])) => self.mvex = Some(MvexBox::read(header, reader).await?),
    ...
}

When it would be reaonable and convenient to be able to do this:

match header.id {
    BoxType::Id(BoxId(b"mvhd")) => self.mvhd = Some(MvhdBox::read(header, reader).await?),
    BoxType::Id(BoxId(b"mvex")) => self.mvex = Some(MvexBox::read(header, reader).await?),
    ...
}

Today it gives:

BoxType::Id(BoxId(b"mvhd")) => self.mvhd = Some(MvhdBox::read(header, reader).await?),
                  ^^^^^^^ expected array `[u8; 4]`, found `&[u8; 4]`

Any plans on implementing a solution ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's Rust examples comparing [u8; 4] constants and byte string literals in match patterns. Review the seven-comment discussion for the proposed behavior and constraints; done means an accepted language design or RFC specifying how these patterns should work.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.