rust-lang / rust-lang/rfcs

Don't make wrong assumptions about the toolchain based on env

Open
#2,695 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-target T-compiler T-lang
Dominant language
Markdown
Stars
6.6k
Forks
1.7k
Avg merge
16h 14m
Merged PRs (30d)
1

Description

Right now a lot of assumptions about the toolchain are made based on the (arch, os, env) part of the triple that are not always true:

  • target_env = "musl" means that a static libc is available
  • target_env = "musl" and dynamic linking means that unwinding is done by libgcc
  • target_env = "musl" and static linking means that unwinding is done by libunwind

In my opinion there should be more specific variables. For example:

  • target_libc - the name of the C library, if any. For example, "glibc", "musl", "newlib", "bionic", "msvc".
    Right now this seems like the role of target_env, however some people have proposed using different target_envs like "dynmusl": https://github.com/rust-lang/rust/issues/59302. "eabihf" and "gnueabihf" are also used.
  • target_builtins - the name of the C builtins library, if any. For example, "libgcc", "compiler_rt". I'm not sure what the situation is with MSVC. For some strange targets it might make sense to leave this unset, indicating that the compiler_builtins crate should provide them instead.
    Right now the compiler_builtins crate seems to be used even when the toolchain can provide the builtins.
  • target_unwind - the unwinding implementation that should be used. For example, "libunwind", "libgcc", "libc++abi". For some strange targets this might be left unset, meaning that unwinding is not supported.
    Right now musl uses libgcc when doing dynamic linking and libunwind when doing static linking.

It should be possible to specify what the toolchain provides and Rust shouldn't #[link] or reimplement:

  • target_provides = "libc" - the libc crate shouldn't try to find -lc. Instead it should assume that the toolchain provides a libc compatible with target_libc.
  • target_provides = "libm" - might be useful if the math stuff is split off of std.
  • target_provides = "builtins" - The compiler_builtins crates should not provide anything.
  • target_provides = "unwind" - The libunwind crate should assume that the unwinding functions that would be provided by target_unwind will magically appear in the binary.

For some targets it makes sense to bundle static libraries inside rlibs. These are the targets where it is expected that the toolchain used by rustc will be unable to/not used to produce C executables. I think this should be indicated by setting target_vendor = "rust".

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Begin by mapping how target_env, target_vendor, compiler_builtins, libc, and libunwind currently determine toolchain behavior; done means those assumptions are replaced by explicit target metadata for libc, builtins, unwinding, and provided libraries.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.