rust-lang / rust-lang/rfcs

drain_filter for all collections

Open
#2,140 7 comments 30 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-collections T-libs
Dominant language
Markdown
Stars
6.6k
Forks
1.7k
Avg merge
16h 14m
Merged PRs (30d)
1

Description

For all collections, provide a method drain_filter. For some discussion of the method name and signature, see https://github.com/rust-lang/rust/issues/43244, especially this comment.

Status
Implemented, awaiting stabilization
Unimplemented
Description

This method mutably borrows the collection and takes a predicate on the elements of the collection (e.g. values for lists and key-value pairs for maps). It then creates an iterator over the elements of the collection where the predicate returned truthfully and accessing that element in the iterator removes it from the collection. For ordered collections, it should return them in order.

Example usage
let v = vec![1, 2, 3, 4, 5, 6, 7, 8];
let primes = v.drain_filter(|n| n.is_prime()).collect::Vec<_>();
assert!(v == vec![1, 4, 6, 8]);
assert!(primes == vec![2, 3, 5, 7]);
Related ideas

Also of use would be a method that finds and removes the first element matching a predicate, as it would not have to do things like pre-poop its pants in case the Drain Where iterator leaks nor would it have to traverse the entire collection if e.g. the first element checked matches the predicate.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Rust issues for the proposed signature and the collection-specific status: Vec and LinkedList, BTreeMap and BTreeSet, HashMap and HashSet, BinaryHeap, VecDeque, and String. Done means determining and implementing the drain_filter API across the listed collections, including predicate-based removal and ordered iteration where applicable.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.