rust-lang / rust-lang/rfcs

Numeric type module constants should be moved into inherent impls

Open
#1,099 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

T-libs
Dominant language
Markdown
Stars
6.6k
Forks
1.7k
Avg merge
16h 14m
Merged PRs (30d)
1

Description

All of the methods provided on our numeric types are part of the inherent impls found in core::num. But the various constants provided for these types (e.g. usize::MAX, i8::MIN, f32::EPSILON) are vended as part of modules named after the types. This seems like it should no longer be necessary now that we have associated constants, and it's confusing because clicking on the documentation for a primitive type (e.g. usize) doesn't show these constants.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the core::num module and the primitive usize documentation linked in the issue, then compare how numeric methods and constants are exposed. Done means the constants are available through the primitive types’ inherent implementations and the separate type-named modules are no longer needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.