rust-lang / rust-lang/reference
Confusing/ambiguous sentence in 'Trait Implementation Coherence' section
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.6k
- Forks
- 607
- PR merge metrics
- PR metrics pending
Description
Items->Implementations->'Trait Implementation Coherence' describes "overlapping implementation instances" with this sentence:
Two trait implementations overlap when there is a non-empty intersection of the traits the implementation is for, the implementations can be instantiated with the same type.
I wanted to fix the grammar, but I couldn't decide what this sentence was supposed to mean. My best guess (changes in bold) is:
Two trait implementations overlap when there is a non-empty intersection of the associated functions the implementation is for, and the implementations can be instantiated with the same type.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Items -> Implementations -> “Trait Implementation Coherence” and read the surrounding explanation of overlapping implementation instances. Confirm what the sentence is intended to express before revising it, then ensure the replacement is grammatically clear and preserves that meaning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100