rust-lang / rust-lang/polonius

break the analysis pipeline into components

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.7k
Forks
86
PR merge metrics
No merged PRs in 30d

Description

Currently, the each Poloniu Algorithm's compute() method performs initialisation analysis, then liveness calculations, and then the actual Polonius implementation. This means a lot of code duplication and in the case of the hybrid algorithm that all of this happens twice.

I suggest the following for a minimal modification to the current setup:

  • the publicly visible compute() method still takes the gigantonormous AllFacts for now
  • internally, these facts are split up into internal data structures consumed by the various compute() methods
  • the calls initiating initialisation and liveness calculations happen in output::compute()

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing each Algorithm's compute() method and output::compute(), then identify where AllFacts is consumed for initialization, liveness, and the Polonius implementation. Done means those stages consume separate internal data structures, initialization and liveness are initiated from output::compute(), and the public compute() interface still accepts AllFacts.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.