rust-lang / rust-lang/libc

1.0: Remove lfs64 API (`open64` and similar)

Open
#4,805 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.6k
Forks
1.3k
Avg merge
1d 22h
Merged PRs (30d)
69

Description

With 1.0 we will default to 64-bit time_t and off_t, and users will need to opt in to 32-bit versions of these APIs - if we expose them at all. This means the API like open64 will be redundant with open. There isn't a reason to use both unless a user opts in to 32-bit off_t but occasionally needs to use 64-bit operations: this doesn't sound like a usecase worth supporting. They also aren't posix.

To back this up, it sounds like musl would deprecate them if they could.

-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE have nothing to do with supporting large files properly but with exposing the idiotic legacy interfaces with 64 on the end of their names (like open64, lseek64, etc.). only -D_FILE_OFFSET_BITS=64 should ever be used, anywhere, even on glibc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the lfs64 bindings and definitions for open64, lseek64, and similar APIs, then review the surrounding platform configuration and tests. Confirm which interfaces are covered by the 1.0 64-bit time_t and off_t defaults; done means the redundant legacy APIs are removed without breaking the remaining platform bindings.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.