Invalid PartialEq implementation for unions
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.6k
- Forks
- 1.3k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 69
Description
union semun, in unix/bsd/apple/mod.rs, has three fields. On LP64, these fields will have unequal sizes. But its PartialEq and Hash implementations only check the smallest field. So the following code should fail (untested, because I don't have access to a Mac):
use libc::semun;
#[test]
fn semun_eq() {
let x = semun{ val: 0x44556677 };
let y = semun{ array: 0x0011223344556677 };
assert!(x != y);
}
A similar situation holds on Linux for __c_anonymous_ptrace_syscall_info_data. That union has three members of different sizes, and its PartialEq implementation will return turn as long as any pair of fields compare equal. Effectively, that means it's only comparing the smallest field.
There are other unions in libc, but I haven't audited them all.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in unix/bsd/apple/mod.rs by examining semun's PartialEq and Hash implementations, then inspect the PartialEq implementation for __c_anonymous_ptrace_syscall_info_data on Linux. Use the provided semun test as a check and audit the other unions in libc. Done means union comparisons and hashing do not ignore larger fields.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100