rust-lang / rust-lang/josh-sync
Incorrect issue references due to GitHub default merge messages
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 31
- Forks
- 15
- Avg merge
- 4d 16h
- Merged PRs (30d)
- 6
Description
When syncing subtree repositories via josh-sync, the default GitHub merge commit message is preserved:
Merge pull request #xxx from owner/branch
As a result, #xxx is resolved against rust-lang/rust instead of the original subtree repository, leading to incorrect issue references.
I'm not sure if this has been discussed before, but rewriting merge commit messages during sync to use:
rust-lang/{subtree-repo}#xxx
would allow references to point to the correct issues.
cc: https://github.com/rust-lang/rust/pull/154980
The commits here refer to the rustc-dev-guide issue, not the rust issue.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin at the josh-sync subtree synchronization entry point and inspect how GitHub merge commit messages are preserved; the issue provides no file or test names. Done means synced merge messages qualify pull-request issue references with the source subtree repository, so GitHub resolves them to the original repository rather than rust-lang/rust.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100