[1.0] Remove some trait impls
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 596
- Forks
- 93
- PR merge metrics
- No merged PRs in 30d
Description
Pattern is currently PartialEq, PartialOrd, Eq, Hash, and Ord. I don't think any of those make sense, it's a compiled representation. We should match https://docs.rs/regex/latest/regex/struct.Regex.html# here and drop these.
It's possible for the user to wrap with a type that implements traits based on .as_str() if they really need this behavior.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Pattern definition and its PartialEq, PartialOrd, Eq, Hash, and Ord implementations. Compare the public trait surface with regex::Regex; done when those implementations are removed and the existing project checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100