rust-lang / rust-lang/glob

[1.0] Change `MatchOptions::default` to match `MatchOptions::new`

Open Beginner friendly
#170 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
595
Forks
93
PR merge metrics
No merged PRs in 30d

Description

https://github.com/rust-lang/glob/blob/97e5ee935a94621df483b5e20a6b6aa07619b4e4/src/lib.rs#L1084-L1091

The Default trait implementation can call new. new could become const.

We don't really need new if we have default, but I think it's fine to keep.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/lib.rs around lines 1084-1091 and compare the MatchOptions::default and MatchOptions::new implementations. Confirm the default implementation delegates to new, consider the noted const possibility, and run the repository's existing tests to verify behavior is unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.