rust-lang / rust-lang/glob

Max glob depth

Open
#161 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
595
Forks
93
PR merge metrics
No merged PRs in 30d

Description

Symlinks can cause the glob mechanism to enter an infinite loop. One approach to limit this is to opt out from following links (as suggested in https://github.com/rust-lang/glob/issues/62), and another one that can be useful to keep the normal behavior of following symlinks while protecting from buggy / malicious directory patterns would be to allow limiting the depth we glob into, which would be a useful feature in MatchOptions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating MatchOptions and the glob traversal entry point. Compare the two proposed approaches—limiting traversal depth or opting out of symlink following—and determine how the chosen behavior should apply to buggy or malicious directory patterns. Done means the selected option is exposed through MatchOptions and its depth or symlink behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.