rust-lang / rust-lang/glob

[1.0] Mark `MatchOptions` `#[non_exhaustive]`

Open
#158 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
596
Forks
93
PR merge metrics
No merged PRs in 30d

Description

https://github.com/rust-lang/glob/pull/144 mentioned adding a sort_paths: bool to MatchOptions, and it would be very nice to have a way to specify the root directory like python. To have forward compatibility with these kind of changes, we should make it #[non_exhaustive] with the next release.

Probably requires an MSRV bump, but the current version is far too old anyway.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the definition of MatchOptions and reviewing the repository's current MSRV and release configuration. Confirm that making the type non-exhaustive provides the requested forward compatibility and that the project still builds and its existing checks pass with the required MSRV change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.