rust-lang / rust-lang/git2-rs

Repository::stash_foreach: accepting a non-mutable reference to repository

Open
#884 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
450
Avg merge
11m
Merged PRs (30d)
1

Description

Why is it that Repository::stash_foreach requires a mutable reference to the repository? Couldn't it be a non-mutable one?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the definition and implementation of Repository::stash_foreach and inspect its related tests or callers. Determine whether the operation requires mutable access, then update the API and coverage so the method accepts an immutable repository reference if appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.