Shouldn't the index.remove method take an enum?
Open
Nobody has claimed this yet.
enhancement
help wanted
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 450
- Avg merge
- 11m
- Merged PRs (30d)
- 1
Description
This method (index.remove) takes an i32 as a stage param, but it is unclear what it does. There are some possible values on the libgit2 documentation, shouldn't be added as an enum?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Index::remove method and the linked libgit2 git_index_stage_t documentation. Determine the intended stage values and how this Rust binding exposes related parameters; done means the stage argument has a clear enum-based API with the existing behavior preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100