rust-lang / rust-lang/git2-rs

Windows binary re-exported libgit2 APIs

Open
#853 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
450
Avg merge
11m
Merged PRs (30d)
1

Description

Hi,

I'm using this library in my project https://github.com/locenv/locenv and the compiled binary for Windows is re-exported libgit2 API, which should not. The example binary that has this issue can be grab from https://github.com/locenv/locenv/actions/runs/2599501164. You should be able to view the exported API with any PE tool (e.g. Dependency Walker). Here is the screenshot from Explorer Suite that shown this issue:

Screenshot from 2022-07-02 06-23-52

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the example Windows binary from the linked locenv Actions run and inspect its exported symbols with a PE tool such as Dependency Walker or Explorer Suite. Then trace the Windows build and linking configuration that produces the binary; done means the compiled binary no longer re-exports libgit2 APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.