rust-lang / rust-lang/git2-rs

Cannot get the size of a modified binary file using "delta.new_file().size()"

Open
#629 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
450
Avg merge
11m
Merged PRs (30d)
1

Description

Hi,

When I try to get the size of a modified binary file, I always get 0 using "delta.new_file().size()", where delta is a gi2::DiffDelta struct. The weird thing is when I use "delta.old_file().size()", I can get the size of the old binary file. However, it does not work for the new file. Does anyone know the reason for this problem?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior described for the gi2::DiffDelta new_file().size() and old_file().size() calls on a modified binary file. Trace how these values are obtained and compare the new-file and old-file paths; done means the new binary size is returned correctly with coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.