rust-lang / rust-lang/git2-rs

credential_helper1 and 3 rely on a shell

Open
#606 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
450
Avg merge
11m
Merged PRs (30d)
1

Description

These tests fail on non-unix systems because they rely on "sh" being available. It's very likely this entire module should be appropriately cfg gated.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the credential_helper1 and credential_helper3 tests and inspect how they invoke sh. Check the surrounding test module's platform configuration, then gate the shell-dependent tests on non-Unix systems and verify the test suite passes there and on Unix.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.