rust-lang / rust-lang/git2-rs

Implement Eq and Ord for Branch?

Open
#422 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.1k
Forks
450
Avg merge
11m
Merged PRs (30d)
1

Description

Since Reference is Eq and Ord, should Branch be also?

I saw the discussion and conclusion in #153, which might apply here too, but figured Branch might be a little different since it's only a wrapper around a Reference. I volunteer to write a PR if this seems like a good idea.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the existing Eq and Ord implementations for Reference and the discussion in #153, then compare them with Branch's wrapper semantics. Determine whether both traits are appropriate for Branch and identify the relevant Branch code and validation needed; done when the decision is implemented and its behavior is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.