`git2::RevparseMode::is_no_single` has a misleading name
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.1k
- Forks
- 450
- Avg merge
- 11m
- Merged PRs (30d)
- 1
Description
https://github.com/rust-lang/git2-rs/blob/da6c126f7733329d82748e710266af1c61591bdd/src/lib.rs#L617
That function returns true when the SINGLE bit is set, but its name implies the opposite. It seems like a typo from the original pull request.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/lib.rs around line 617 and inspect RevparseMode::is_no_single plus its callers. Confirm the name is inconsistent with the returned SINGLE-bit behavior, update the name and all references, and verify the project still builds and tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100