rust-lang / rust-lang/fls

[Change]: Remove no_link attribute

Open
#665 3 comments 0 reactions 1 assignee View on GitHub

@PLeVasseur is already working on this.

Since Feb 19, 2026.

Dominant language
reStructuredText
Stars
497
Forks
41
Avg merge
3h 52m
Merged PRs (30d)
4

Description

Change description

Remove the #[no_link] attribute

Area

linkage

Category

Other

FLS Paragraph ID

fls_ch9nkxkloozv

Change description (extended)

This is a pre-1.0 attribute that accidentally got stabilized. It was meant for compiler plugins, not regular crates. https://github.com/rust-lang/rust/issues/152854#issuecomment-3927429479 It is also rather fragile. If you use any function defined inside a crate you import using #[no_link] it might or might not work depending on if another crate has a normal dependency on it, if the function is codegened cross-crate and if the call site is optimized out or not. As such I think it should be deprecated and eventually removed. Even if we chose not to remove it from Rust, I do think it should not be documented in the FLS to avoid this fragile behavior in safety critical systems.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.