rust-lang / rust-lang/docs.rs

re-add logging build output for cli/toolchain-update builds

Open
#3,410 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.2k
Forks
233
Avg merge
11h 35m
Merged PRs (30d)
60

Description

After https://github.com/rust-lang/docs.rs/pull/3203 we stopped writing the whole build output to logs under the assumption that our uploaded build logs will cover this.

But we have cases were we don't update build logs. Off the top of my head:

  1. adding essential files after toolchain updates
  2. manual builder build {crate} builds

especially 1) made debugging an issue hard.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request 3203 and the code paths for cli/toolchain-update builds and manual builder build {crate} builds. Reproduce both cases and trace where build output is currently logged or omitted. Done means the whole build output is written to logs for toolchain-update recovery work and manual builder builds.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, cli, observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
56/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.