yanks might get ignored when the build is still queued
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.2k
- Forks
- 232
- Avg merge
- 11h 35m
- Merged PRs (30d)
- 60
Description
So it's not forgotten I'll write down my findings here.
When we get a Yank change from crates-index-diff, we are running an UPDATE statement on the releases table.
We only add the release to that table after the build is finished, so when the release is still in our build-queue, or in progress, the yank wouldn't do anything.
Since we don't check the number of updated rows for that UPDATE statement, this also never lead to an error.
While we could solve this issue by storing the yank-state in the build-queue too, this could also be solved via solving #1011.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the crates-index-diff Yank handling and the UPDATE against the releases table, then read issue #1011 and the build-queue flow. Determine how a yank should be preserved while a release is queued or building; done means the yank is not silently ignored before the release row exists, with the chosen approach verified by relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100