rust-lang / rust-lang/docs.rs

/crate is no longer reachable without javascript

Open
#1,103 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-frontend C-bug
Dominant language
Rust
Stars
1.2k
Forks
233
Avg merge
11h 35m
Merged PRs (30d)
60

Description

This is a regression introduced by https://github.com/rust-lang/docs.rs/pull/1081 - since dropdowns open using javascript, and clicking on the dropdown itself no longer goes to a new page, there's no longer a way to go to /crate without javascript enabled (or typing the URL in manually).

Rather than reverting the PR, I think the fix should be to make dropdowns open using CSS instead. That may not be feasible - if so, I think I would prefer to revert the PR so the site is still usable without JS.

cc @jsha, do you have time to follow-up on this?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request 1081 and the dropdown implementation it introduced. Check how the /crate link behaves with JavaScript disabled, then determine whether CSS-only dropdown behavior preserves navigation; done means /crate remains reachable without JavaScript, or the change is reverted if that is not feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
accessibility, frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.