rust-lang / rust-lang/datafrog
Convert `RelationLeaper` trait into `Relation` methods
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 899
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
The RelationLeaper trait is implemented by Relation and has some extra methods for constructing leapers. However, it would be simpler if they were defined directly on the struct rather than a trait plus its implementation.
The trait doesn't look necessary because it's only implemented by Relation, and intra-doc links don't currently work for implementations of a trait. In #52 I linked to the trait methods, but it would have been cleaner to link directly to Relation's methods.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the RelationLeaper trait and its implementation for Relation, then compare the leaper-construction methods with the surrounding Relation API. Move the methods onto Relation and update the intra-doc links mentioned in #52; done means the trait is no longer needed and the links point directly to Relation methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100