rust-lang / rust-lang/cargo

auth-scheme missing from Authorization header when talking to registry

Open
#4,989 11 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-registries A-registry-authentication S-needs-design
Dominant language
Rust
Stars
15.5k
Forks
3k
Avg merge
23h 30m
Merged PRs (30d)
51

Description

We currently generate a header that looks like Authorization: asdfasdfasdfasdf: https://github.com/rust-lang/cargo/blob/868d37339117213fdef4ead8daf4a9557cc4ec89/src/crates-io/lib.rs#L172

This does not match up with the grammar specified in RFC 7235, however:

credentials = auth-scheme [ 1*SP ( token68 / #auth-param ) ]
Authorization = credentials

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the linked src/crates-io/lib.rs location and compare the generated Authorization header with the auth-scheme and credentials grammar in RFC 7235 section 2.1. Done means registry requests emit an Authorization header containing the required authentication scheme rather than the token alone.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
authentication
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.