rust-lang / rust-lang/bors

Squashing broke the commit message when there's code spans in quotes

Open
#773 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
176
Forks
65
Avg merge
1d 3h
Merged PRs (30d)
13

Description

https://github.com/rust-lang/rust/pull/134021#issuecomment-4826671640

bors squash msg="Implement IntoIterator for [&[mut]] Box<[T; N], A>"

gave a squashed commit message of:

Implement  for

Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the bors squash msg="..." command from the linked issue comment, then trace bors's squash commit-message handling. Done means quoted code spans are preserved in the squashed commit message, rather than being removed, while the existing message metadata remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.