rust-lang / rust-lang/book

Images have a white background even with dark themes

Open
#74 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Enhancement Online only
Dominant language
Rust
Stars
18.3k
Forks
4.1k
Avg merge
14m
Merged PRs (30d)
1

Description

/cc @Mark-Simulacrum

We might be able to just make the background transparent, but then the black text would be tough.

@azerupi is there even a way to switch images based on theme? That's another solution.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Read the discussion first to determine whether theme-specific images or transparent backgrounds are intended, then identify the book's image and theme handling; done means images remain readable in dark themes.

Written by the indexing model from the issue text.

Assessment

Domain
design, documentation
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.