rust-lang / rust-lang/backtrace-rs
`deny(unsafe_op_in_unsafe_fn)` in backtrace-rs
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 628
- Forks
- 291
- PR merge metrics
- No merged PRs in 30d
Description
Because backtrace-rs is included as a submodule and has platform-specific code, this lint is currently allowed inside std. I intend to remove this allow in std for this crate, and deny this lint inside backtrace.
There is platform-specific code in this crate. For most platforms, most of it is fairly limited, and limited to safe functions, so that there is no concern with this lint. There is, however, the divide between DWARF (or "Unix") and PDB (or "Windows"), on which pretty much everything else about this crate hinges. This should be... comparatively easy? to fix?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the crate's platform-specific DWARF/Unix and PDB/Windows code, then review the unsafe operations affected by denying unsafe_op_in_unsafe_fn. Enable the lint in backtrace and verify that the crate builds and its existing tests pass across the relevant platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100