rust-lang / rust-lang/backtrace-rs
current-exe-mismatch.rs test may be too eager to ignore its failings
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 628
- Forks
- 291
- PR merge metrics
- No merged PRs in 30d
Description
Spawned off of https://github.com/rust-lang/backtrace-rs/pull/488#discussion_r1003972728
The newly added current-exe-mismatch.rs is a bit over-eager to categorize problems as "ignorable" rather than providing some way to flag them as a hard-error in certain contexts.
The main example: while it is not reasonable to expect readelf to exist on every target, it may be reasonable to assume its available on Linux (yes?), and thus maybe a readelf invocation failure should be ignored on non-Linux systems, but a test failure on Linux systems. (Or maybe just treat it as a test failure on Linux Continuous Integration hosts, which is what we really care about here...)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the current-exe-mismatch.rs test and the discussion from pull request 488, focusing on how readelf invocation failures are classified. Determine the intended Linux or CI behavior, then make completion explicit by ensuring failures are ignored only on unsupported systems and reported where the project expects them to be hard errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100