spi: add settings to embedded-hal-bus SpiDevice impls for CS-to-clock delays.

Open
#539 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
embedded-iot

Research direction

Start by locating the SpiDevice implementations in embedded-hal-bus and reviewing how Operation::DelayNs is currently documented. The work is complete when the SpiDevice implementations expose settings for CS-assert-to-clock and clock-to-CS-deassert delays, and the documentation discourages drivers from using Operation::DelayNs directly for those delays.

Written by the indexing model from the issue text.

Description

As discussed in today's meeting:

It is better if the CS-assert-to-clock and clock-to-CS-deassert delays are configured in the SpiDevice itself, so that the driver doesn't have to add them to every single transaction, and can use the read/write/write_read convenience methods.

  • add configuration settings to the SpiDevice impls in embedded-hal-bus to do the delays
  • document that drivers are discouraged from using Operation::DelayNs directly for CS-to-clocks delays.
Dominant language
Rust
Stars
2.7k
Forks
282
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-embedded/embedded-hal

All issues in rust-embedded/embedded-hal

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.