TryInto instead of Into

Open
#307 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
rust
Domain
embedded-iot

Research direction

Open src/nb/timer.rs at line 69 and inspect the conversion bound used there. Check the surrounding timer code and existing tests or build results, then replace the conversion approach as requested so Kilo/Megahertz values work with embedded-time. Done means the relevant crate checks or tests pass.

Written by the indexing model from the issue text.

Description

https://github.com/rust-embedded/embedded-hal/blob/3dcb672bfcff83d8e672ae41cd203a9c6a9c8b4c/src/nb/timer.rs#L69

During moving to embedded-time I found Into<Hertz> is not implemented for Kilo/Megahertz

Dominant language
Rust
Stars
2.7k
Forks
282
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-embedded/embedded-hal

All issues in rust-embedded/embedded-hal

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.