rust-cli / rust-cli/env_logger
Trivial: the systemd example misuses RUST_LOG_STYLE
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.1k
- Forks
- 149
- Avg merge
- 2h 42m
- Merged PRs (30d)
- 4
Description
I might be wrong, but the systemd example (added in #157) overloads RUST_LOG_STYLE. Since that is parsed internally by env_logger, I think the example is suboptimal; it would be better to control the systemd-vs-non-systemd and style separately, as long as systemd is not directly supported (which would be best, actually, as a new WriteStyle).
I might misunderstand the way the WriteStyle is supposed to work though, not sure.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the systemd example added in #157 and trace how env_logger parses RUST_LOG_STYLE and how WriteStyle is intended to work. Clarify whether the change should separate systemd selection from style or add direct systemd support through a new WriteStyle; done requires an agreed design and a corrected example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100