rust-cli / rust-cli/config-rs

No option to trim whitespace from env values

Open
#768 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-env C-enhancement S-triage
Dominant language
Rust
Stars
3.2k
Forks
265
Avg merge
2h 42m
Merged PRs (30d)
4

Description

Currently, there is no way to trim leading and trailing whitespace from environment variable values. Also, trimming would be helpful in list separator too: APP_LIST="a, b, c" should yield to ["a", "b", "c"] with no leading spaces for a and b.

A possible solution would be an opt-in method, leaving the current behaviour as the default:

Environment::with_prefix("APP")
    .trim_values(true)
    .try_parsing(true);

The value should be trimmed before any further processing.

I prepared a PR #767 to add this feature with a bunch of tests describing the behaviour.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Environment::with_prefix entry point and review PR #767, including its tests describing the requested behavior. Done means opt-in trimming occurs before further processing, list separators remove surrounding spaces, and the current default behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.