rust-cli / rust-cli/config-rs

Can ENV not be forced to lowercase? Or Case could add a support for converting to AA_BB instead of AA BB

Open
#672 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-env
Dominant language
Rust
Stars
3.2k
Forks
265
Avg merge
2h 42m
Merged PRs (30d)
4

Description

let mut key = key.to_lowercase()
Because I see that ENV is forced to be lowercased here, if my struct is renamed to uppercase and underscored, the ENV parsing will fail consistently.
I tried using convert_case(config::Case::Upper) but it fails if there is an underscore. Now in order to support env, I have to make it all lowercase and underlined.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read src/env.rs at the linked conversion around line 260, then inspect how convert_case(config::Case::Upper) handles underscores. Reproduce the reported environment-variable parsing failure and determine the expected uppercase, underscored form; done means the requested case conversion works for environment keys without breaking existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.